feat: allow running specific inline scripts on main thread #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
loadScriptsOnMainThread
functionality to inline scripts. This modification is required to address a common scenario in which an inline script sets up the environment for another script loaded from the network.Inline scripts are targeted using the
id
attribute.Let's assume that the following snippet is a custom HTML tag in GTM:
Now, using the following configuration:
both scripts will be executed on main thread, but I can still controlled them with GTM from Partytown.
This PR is not enough to run GTM's custom html tag on the main thread. A bug in
innerHTML
implementation for theHTMLScriptElement
should be fixed too. I created a PR with proposed, although not ideal fix #234