Add filter and CRUD tests for AutoIncrement field #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 5884503 We got this. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue. |
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
from
9c0ed65
to
7b85de7
Compare
timleslie
suggested changes
Aug 18, 2020
api-tests/fields.test.js
Outdated
|
|
||
| describe('Fields', () => { | ||
| const testModules = globby.sync( | ||
| [`packages/**/src/**/test-fixtures.js`, `!packages/fields-auto-increment/src/test-fixtures.js`], |
There was a problem hiding this comment.
I don't like having package-specific code in this general file. Can we find a way to implement this logic in such a way that it becomes part of the test-fixtures.js configuration?
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
2 times, most recently
from
515a3b5
to
d60c7b7
Compare
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
3 times, most recently
from
2a4d218
to
228a8aa
Compare
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
2 times, most recently
from
9dde602
to
1898cad
Compare
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
4 times, most recently
from
6f87bcb
to
0026596
Compare
singhArmani
force-pushed
the
add-filter-tests-autoincrement
branch
from
0026596
to
5884503
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapterspecific field API tests.fields.test.jsto insert items in an order as in array returned byinitItems()function of the module.